Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update coverage plugin with latest components #2294

Merged
merged 5 commits into from
Jul 18, 2024
Merged

feat: update coverage plugin with latest components #2294

merged 5 commits into from
Jul 18, 2024

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jul 9, 2024 •
edited
Loading

Description

Added/Updated following components -

  • Accordion
  • Drawer
  • Menu
  • Step Group
  • Top Nav
  • FileUpload
  • ButtonGroup

image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ce1b583

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 9, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ce1b583:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented Jul 9, 2024 •
edited
Loading

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
⬇ BladeProvider 1.709 1.708 -0.001 KB
⬆ TextInput 33.270 33.271 +0.001 KB

Generated by 🚫 dangerJS against ce1b583

saurabhdaware
saurabhdaware approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One doubt below

packages/plugin-figma-blade-coverage/README.md
@@ -81,6 +76,32 @@ It excludes the following nodes from coverage calculation:

<br/>

## Local Development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

packages/plugin-figma-blade-coverage/src/bladeLibraryConstants.ts
Comment on lines +100 to +103
L2SubMenuItem: {
key: '06cc9d71153af14dc0ec0cb22835596420fa7c93',
},
L1SubMenuItem: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which components are these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

@saurabhdaware saurabhdaware merged commit b547c18 into master Jul 18, 2024
14 of 15 checks passed
@saurabhdaware saurabhdaware deleted the coverage-plugin-enhancements branch July 18, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhdaware saurabhdaware saurabhdaware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snitin315 @rzpcibot @saurabhdaware